On Wed, 19 Aug 2026 17:03:10 GMT, Matias Saavedra Silva <[email protected]> wrote:
>> When performing an AOT training run using a multi-release JAR file, the >> following warning can be encountered: >> `[warning][aot] class org/example/Foo cannot be archived because it was not >> defined from <path to mr.jar> as claimed` >> This warning results from a specific configuration of the JAR file where the >> class is not in the root directory but is present in the versioned directory >> `META-INF/version`. To fix this, an upcall to ClassLoader.getResource() is >> now made in the specific case where a multi-release JAR is being used and >> the class cannot be found through normal means. Verified with tier 1-5 tests. >> >> >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matias Saavedra Silva has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 10 additional > commits since the last revision: > > - Merge branch 'master' into version_class_jar_8380847 > - Added assert > - Ioi offline comments > - Coleen and Alan comments > - Ioi offline comments > - Fixed build issues > - Cleanup > - Moved upcall to CDS.java > - Cleanup > - 8380847: Versioned class loaded from multi-release jar file is not cached This looks good. src/hotspot/share/classfile/classLoader.cpp line 408: > 406: current); > 407: > 408: // Not using TRAPS, the thread must be checked manually Technically, you're not using "CHECK". ------------- Marked as reviewed by coleenp (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32087#pullrequestreview-4977302802 PR Review Comment: https://git.openjdk.org/jdk/pull/32087#discussion_r3817190365
