On Thu, 20 Aug 2026 23:59:37 GMT, Alexey Semenyuk <[email protected]> wrote:

>> - Added `--app-resources`.
>> 
>> Specification:
>> 
>> --app-resources
>> 
>>     A File.pathSeparator separated list of paths
>> 
>>     Additional application files and directories to copy into the
>>     application resources directory.
>> 
>>     This option may be specified multiple times.
>> 
>>     Destination:
>>         Windows: application image root
>>         Linux: application image lib directory
>>         macOS: Contents/Resources
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> test/jdk/tools/jpackage/share/AppContentAndResourcesTest.java line 280:
> 
>> 278:     }
>> 279: 
>> 280:     private record TestCase(AppFilesOption option, TestSpec spec) {
> 
> I think this new abstraction is redundant. You can just add `AppFilesOption 
> option` field to the existing `TestSpec` and `TestSpec.Builder` classes.

Added a patch that adds the `AppFilesOption option` field to `TestSpec` and 
`TestSpec.Builder` classes.

[AppContentTest.java.patch](https://github.com/user-attachments/files/31285515/AppContentTest.java.patch)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32474#discussion_r3826402013

Reply via email to