On Wed, 26 Aug 2026 14:01:34 GMT, Jaikiran Pai <[email protected]> wrote:
>> Agreed. So where to go from here?
>>
>> * Keep the current PR as-is, or simplify implementation to less conservative
>> but slightly shorter alternative?
>> ```java
>> @Override
>> public String readAllAsString() throws IOException {
>> return sd.readAllAsString();
>> }
>> ```
>> ```java
>> @Override
>> public String readAllAsString() throws IOException {
>> synchronized (lock) {
>> ensureOpen();
>> if (in != null && decoderFromCharset && !readCalled) {
>> return new String(in.readAllBytes(), cs);
>> }
>> return super.readAllAsString();
>> }
>> }
>> ```
>>
>> * Keep the current PR as-is, or removing some of the new tests?
>>
>> * Whom to ask as second reviewer, as nobody responded so far?
>
> Hello Markus,
>
>> Whom to ask as second reviewer, as nobody responded so far?
>
> I have been watching the discussion and letting the changes settle. I guess
> others might be doing the same. I or someone else will act as a second
> reviewer.
> Keep the current PR as-is, or simplify implementation to less conservative
> but slightly shorter alternative?
I think they are equivalent right now. As I said, it's really just a concern
that an override in the ISR wrapper might lead an issue when the delegate
involves its super.readAllAsString and so doesn't call something in the wrapper
that the subclass might expect.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32264#discussion_r3874091325
