On Fri, 21 Aug 2026 00:23:39 GMT, Guanqiang Han <[email protected]> wrote:
>> Please review this change, thanks! >> >> **Description:** >> >> Some VM long options only accept arguments in the `--option=value` form, >> even though the launcher help states that long-option arguments may also be >> separated by whitespace. As a result, options such as >> `--illegal-final-field-mutation debug`, `--illegal-native-access warn` are >> not parsed correctly. >> >> **Solution:** >> >> Add `IsNonModuleVMWhiteSpaceOption()` to identify VM long options that >> accept whitespace-separated arguments and convert them to the >> `--option=value` form before passing them to the VM. Add >> `--enable-final-field-mutation` to the existing module-option handling. >> Normalize missing arguments for other VM long options to `--option=` so that >> they can be handled by the existing option validation logic. >> >> **Test:** >> >> GHA >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Guanqiang Han has updated the pull request incrementally with one additional > commit since the last revision: > > Move main() before launch() and test() for readability Hello Alan, > I see you've assigned the "REDO" to yourself but I assume Guanqiang should > take it and add the changes to work in this test execution mode. I don't plan to work on the REDO. The reason I assigned to myself is so that I can have any proposed changes run against our CI when it's time to integrate. I'll assign this to Guanqiang to avoid any confusion. > The CSR will need to get re-linked too. That's already been done. ------------- PR Comment: https://git.openjdk.org/jdk/pull/31928#issuecomment-5449664589
