On Mon, 31 Aug 2026 14:15:54 GMT, Matthias Baesken <[email protected]> wrote:
> Some RegCloseKey calls on hSubKey are missing; and the "NT 4.0 SP3" coding in > the file looks a bit outdated - is it maybe some leftover from older coding ? > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Looks good to me. > The whole coding below (line 320 and following) looks strange Yeah, it does. As far as I can dig, this is the issue that introduced the piece: https://bugs.openjdk.org/browse/JDK-4400869, which suggests Windows implementations were fragile across versions and/or languages. So I guess it makes sense to just remove this piece, but that is for another opportunity. ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32608#pullrequestreview-5072059777
