On Tue, 1 Sep 2026 10:23:59 GMT, Alan Bateman <[email protected]> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added test cases
>
> src/hotspot/share/cds/aotClassLocation.cpp line 286:
>
>> 284: if (StringUtils::strstr_nocase(cs->manifest(), "Multi-Release: true")
>> != nullptr) {
>> 285: cs->_is_multi_release_jar = true;
>> 286: }
>
> I see you've added a test to make sure the check is case insensitive, and a
> test for `-Djdk.util.jar.enableMultiRelease=false`, good. What happens with
> `Multi-Release: truex`. This will not be treated as a MR JAR in the Java code
> but it looks like AOTClassLocation::allocate will set _is_multi_release_jar
> to true. It may not cause an issue but I think needs to be checked.
It looks like this is an issue that predates my change. I think it's reasonable
to try and fix it here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32087#discussion_r3907136627
