On Wed, 2 Sep 2026 17:00:25 GMT, Chen Liang <[email protected]> wrote:
>> Xueming Shen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update
>
> test/jdk/jdk/incubator/vector/VectorLanewiseOpCompatibleWithTest.java line
> 178:
>
>> 176: vector.lanewise(ternary, vector, vector, mask);
>> 177: }
>> 178: default -> throw new AssertionError("Not a lanewise
>> operator: " + op);
>
> Isn't it better to add a new case like:
>
> case VectorOperators.Test test -> {
> vector.test(op);
> vector.test(op, mask);
> }
>
>
> Same for `testUnsupportedOperator`. Don't need all these new unit tests.
good catch/suggestion :-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32633#discussion_r3916700060
