On Thu, 3 Sep 2026 12:48:32 GMT, Marc Chevalier <[email protected]> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pseudocode
>
> src/hotspot/share/opto/int128tnode.hpp line 46:
>
>> 44: Node* hi2() const { return in(4); }
>> 45:
>> 46: virtual const Type* bottom_type() const override final { return
>> TypeTuple::LONG_PAIR; }
>
> Nit: `override` and `virtual` are redundant with `final`. C++ can make an
> avalanche of symbols, we don't need to make it compete with an avalanche of
> keywords 🙂 . Usually, it is recommended to use only one of `override` or
> `final` (and `virtual` only in the base). Same under, and other classes.
You are right, I was too excited with those specifiers 😆 Since `final` implies
`override`, which in turns implies `virtual`, keeping only `final` is adequate.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31008#discussion_r3926025103
