On Thu, 3 Sep 2026 12:50:41 GMT, Francisco Ferrari Bihurriet
<[email protected]> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 43 commits:
>>
>> - Merge
>> - Add test for modular image using customized java.security file.
>> Add other various improvements and tests for different property syntax.
>> - Use Properties API to parse each property.
>> Add method to determine if props file has comments or blank lines.
>> Add method to determine if property is multi-lined value.
>> Store props in Properties object instead of Map.
>> - Add extract method to JModTask.
>> - Revert change made to java.security file.
>> - Support lines of just whitespace.
>> - Support all delimiters ('=', ':', whitespace)
>> - Use ISO_8859_1 to read/write property files.
>> Improve SkippedException message.
>> - Alternate jlink --security-properties implementation. There is no separate
>> option for the include file.
>> - Document that comments in the properties file are ignored.
>> - ... and 33 more: https://git.openjdk.org/jdk/compare/9c6e2f49...55f102ed
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties line
> 183:
>
>> 181:
>> 182: security-properties.usage=\
>> 183: \ --security-properties props=<filename>\n\
>
> It seems 79aa0d7af1264737d1724cee039f4f02315aee70 forgot to remove `props=`
> here.
Good catch - fixed in
https://github.com/openjdk/jdk/pull/31884/changes/529c4a6c24734225cfa21cb69b1df9e080b43e77
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31884#discussion_r3926866490
