On Thu, 3 Sep 2026 14:15:10 GMT, Francisco Ferrari Bihurriet
<[email protected]> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 43 commits:
>>
>> - Merge
>> - Add test for modular image using customized java.security file.
>> Add other various improvements and tests for different property syntax.
>> - Use Properties API to parse each property.
>> Add method to determine if props file has comments or blank lines.
>> Add method to determine if property is multi-lined value.
>> Store props in Properties object instead of Map.
>> - Add extract method to JModTask.
>> - Revert change made to java.security file.
>> - Support lines of just whitespace.
>> - Support all delimiters ('=', ':', whitespace)
>> - Use ISO_8859_1 to read/write property files.
>> Improve SkippedException message.
>> - Alternate jlink --security-properties implementation. There is no separate
>> option for the include file.
>> - Document that comments in the properties file are ignored.
>> - ... and 33 more: https://git.openjdk.org/jdk/compare/9c6e2f49...55f102ed
>
> Hi @seanjmullan, thank you for the updates, I discovered other potential
> problems with the escaping of user-defined properties.
@franferrax The CSR has been approved for this change and I have Alan's
approval to integrate. I believe I have resolved all of your comments. I plan
to integrate early next week. But let me know you need more time to review the
latest updates. Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/31884#issuecomment-6201003462
