On Sat, 5 Sep 2026 16:53:45 GMT, ExE Boss <[email protected]> wrote:

> Also include the `IllegalArgumentException` check that’s on the next line 
> inside this `if`:
> 
> https://github.com/openjdk/jdk/blob/d249d987974b0794ca48bfbcd96cc9a487d6f736/src/java.base/share/classes/java/lang/module/ModuleDescriptor.java#L1122-L1123

Thanks for the suggestion. I changed the pre-release parsing to use an outer 
`if (c == '-')`.

I kept the following `IllegalArgumentException` check outside the `if`. It 
checks that `+` is followed by a build component. Moving it inside would mean 
that `1+` does not reach the check, while `1-a+` does.

I also added tests for `1+` and `1-a+`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32715#discussion_r3942965900

Reply via email to