On Sun, 6 Sep 2026 04:03:37 GMT, Chen Liang <[email protected]> wrote:
>> Quan Anh Mai has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - Merge branch 'master' into int128 >> - Fix typos >> - Remove redundant keywords >> - Pseudocode >> - Merge branch 'master' into int128 >> - Use TypeTuple::LONG_PAIR >> - Merge branch 'master' into int128 >> - C++17 >> - Merge branch 'master' into int128 >> - Merge branch 'master' into int128 >> - ... and 2 more: https://git.openjdk.org/jdk/compare/f0952f6c...53b59c71 > > src/java.base/share/classes/jdk/internal/misc/Int128T.java line 33: > >> 31: * implementation of corresponding C2 nodes. >> 32: */ >> 33: public class Int128T { > > Let's make this utility class final and add a private constructor. Thanks for your review. That makes sense, I have renamed the class to `jdk.internal.math.Int128Math`, made it `final` and added a private constructor. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31008#discussion_r3943029015
