On Tue, 8 Sep 2026 15:14:27 GMT, Pavel Rappo <[email protected]> wrote:
>> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps.properties
>> line 137:
>>
>>> 135: \ compile-time view analysis and
>>> print\n\
>>> 136: \ dependency summary. This option must
>>> be used\n\
>>> 137: \ with the --require, --package, or
>>> --regex option.
>>
>> The rest of the proposed changes look reasonable to me. I have to wonder
>> though if the option `must be used`, `can be used`, or `may be used`...
>
> I believe the correct word is MUST, as in required/necessary. Here's the
> reason (* is mine):
>
>
> class InverseAnalyzeDeps extends AnalyzeDeps {
> InverseAnalyzeDeps() {
> }
>
> @Override
> boolean checkOptions() {
> if (options.recursive != -1 || options.depth != -1) {
> reportError("err.invalid.options", "--recursive and
> --no-recursive", "--inverse");
> return false;
> }
>
> if (options.numFilters() == 0) { // *
> reportError("err.filter.not.specified");
> return false;
> }
>
>
> As for the grammar, I was going to fix it in "This option must use with
> --require ..." when it occurred to me to compare that bit with that of
> manpage. The manpage wording was good, so I copied it verbatim.
Heh, it's even simpler:
% jdeps --inverse
Error: --package (-p), --regex (-e), --require option must be specified
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32701#discussion_r3959430032
