On Mon, 7 Sep 2026 07:49:21 GMT, Alan Bateman <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/json' into
>> JDK-8381976-Implementation-for-Simple-JSON-API
>> - Replace in-line occurrences of RFC 8259 with link
>> - CSR review - JV.toString()
>
> src/jdk.incubator.json/share/classes/jdk/incubator/json/JsonObject.java line
> 38:
>
>> 36: * The interface that represents JSON object.
>> 37: * <p>
>> 38: * A {@code JsonObject} can be produced by {@link Json#parse(String)}.
>
> At some point, the package description was updated to have "can be done with
> Json.parse(String) or Json.parse(char[])". Do you want to add the overload
> to JsonObject (and the other classes) too. Initially I was wondering about
> "produce" vs. "done" too but it's probably okay for now, maybe smooth out
> some of the wording in a future update.
I see Justin has addressed this.
> src/jdk.incubator.json/share/classes/jdk/incubator/json/JsonValue.java line
> 310:
>
>> 308: * The default implementation returns {@link Optional#empty} if this
>> 309: * {@code JsonValue} is an instance of {@code JsonNull}; otherwise
>> 310: * {@link Optional#of} given this {@code JsonValue}.
>
> "otherwise Optional.of given this JsonValue" is a bit awkward, something like
> "otherwise Optional.of(this)" might be clearer.
I see Justin has addressed this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32282#discussion_r3960434994
PR Review Comment: https://git.openjdk.org/jdk/pull/32282#discussion_r3960434556
