On Wed, 9 Sep 2026 09:32:17 GMT, Viktor Klang <[email protected]> wrote:

>> Hi @amaembo @JnRouvignac @viktorklang-ora 
>> Thanks all for the review. Agreed the sorted specialization has little 
>> benefit with a persistent HashSet, and I haven't benchmarked it yet. Given 
>> the compareTo/equals compatibility concerns, what direction do you prefer 
>> for JDK-8223933 — leave as-is, apply a full equals-based fix, or something 
>> else? I'll update or withdraw the PR accordingly.
>
> @tusharsaini18899 My personal opinion here is that I don't think this is 
> fixable without significant risk of semantically altering pre-existing code, 
> so my vote is unfortunately "Leave things as they are" (unless some other 
> solution is discovered).

@viktorklang-ora  Thanks — that makes sense. I agree the compatibility risk is 
real. so I'll withdraw this PR for now and leave JDK-8223933 as-is unless a 
safer approach comes up.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32670#issuecomment-5604434049

Reply via email to