On Tue, 8 Sep 2026 21:52:52 GMT, Naoto Sato <[email protected]> wrote:
>> Three options were suggested about the new API: >> - ListFormat.formatting() >> - ListFormat.toCollector() >> - Collectors.listFormatting(ListFormat) static method >> I feel it should belong to ListFormat, but I'm open to discussions. >> >> For testing, I tested a couple of scenarios and a few corner cases (empty >> stream, null element, parallel stream) in a simple non-parameterized JUnit >> test. I believe that it's enough, given that the implementation is trivial, >> and ListFormat itself, as well as Stream API is already thoroughly tested by >> other tests. Tell me if you feel that some testing scenarios are missing, >> I'll happily add them. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Thanks for the PR, Tagir. > > I think of this functionality as "localized joining", so I would have had > `Collectors.joining(listFormat)` but that is not possible I suppose, because > it would conflict with the overload that takes `CharSequence`. Maybe > `Collectors.joiningLocalized(listFormat)` static method? This would highly > help discoverability of the functionality as @viktorklang-ora mentioned. @naotoj thank you for the review. I can rewrite it to `joiningLocalized` and update CSR if @viktorklang-ora agrees. I guess it would be better to move tests to CollectorsTest.java? ------------- PR Comment: https://git.openjdk.org/jdk/pull/32716#issuecomment-5601925813
