On Mon, 31 Aug 2026 11:12:22 GMT, Alan Bateman <[email protected]> wrote:
> This is the update to make STS a permanent API. `@PreviewFeatures` is dropped > the `@since` tags bumped to 28. Tests are updated to drop `@enablePreview`. > > There are several updates to the API docs. All are local, there no > significant refactoring of the API docs. The first example is moved closer to > the top and several areas of the docs are changed to improve readability. > > Testing: Tier1-3 > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Great stuff! (Would be preferable if another reviewer also signs off on this) src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java line 1342: > 1340: * > 1341: * <p> This method works exactly the same as {@link > #fork(Callable)} except that the > 1342: * parameter to this method is a {@link Runnable}; the new thread > executes its Semi-colon intentional? Another alternative is to put a colon after "except" and then use commas. src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java line 1367: > 1365: * It returns {@code null} if all subtasks complete successfully. > It throws {@link > 1366: * ExecutionException} if any subtask fails, with the exception > from the first subtask > 1367: * to fail as the {@linkplain Throwable#getCause() cause}. If a > {@linkplain "Is it "first" as in order or "first" as in time?" is a question a reader might ask. "Earliest" might be a better choice of word if it is temporally the first. test/jdk/jdk/internal/misc/ThreadFlock/ThreadFlockTest.java line 898: > 896: try (var flock1 = ThreadFlock.open("flock1")) { > 897: try (var flock2 = ThreadFlock.open("flock2")) { > 898: assertThrows(StructureViolationException.class, > flock1::close); Nice simplification! ------------- Marked as reviewed by vklang (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32602#pullrequestreview-5179111743 PR Review Comment: https://git.openjdk.org/jdk/pull/32602#discussion_r3988817247 PR Review Comment: https://git.openjdk.org/jdk/pull/32602#discussion_r3988835067 PR Review Comment: https://git.openjdk.org/jdk/pull/32602#discussion_r3989529729
