On Fri, 11 Sep 2026 11:47:35 GMT, Viktor Klang <[email protected]> wrote:
>> This is the update to make STS a permanent API. `@PreviewFeatures` is >> dropped the `@since` tags bumped to 28. Tests are updated to drop >> `@enablePreview`. >> >> There are several updates to the API docs. All are local, there no >> significant refactoring of the API docs. The first example is moved closer >> to the top and several areas of the docs are changed to improve readability. >> >> Testing: Tier1-3 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java > line 1342: > >> 1340: * >> 1341: * <p> This method works exactly the same as {@link >> #fork(Callable)} except that the >> 1342: * parameter to this method is a {@link Runnable}; the new thread >> executes its > > Semi-colon intentional? Another alternative is to put a colon after "except" > and then use commas. It works as a continuation but using a period to make it two sentences is probably better here. > src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java > line 1367: > >> 1365: * It returns {@code null} if all subtasks complete successfully. >> It throws {@link >> 1366: * ExecutionException} if any subtask fails, with the exception >> from the first subtask >> 1367: * to fail as the {@linkplain Throwable#getCause() cause}. If a >> {@linkplain > > "Is it "first" as in order or "first" as in time?" is a question a reader > might ask. "Earliest" might be a better choice of word if it is temporally > the first. It's "any", and more of an quality-of-implementation topic to fail with the exception from the earliest subtask to fail. I'd prefer not try to being "earliest" into API docs, I'll re-word this to say that it's the exception from a failed subtask. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32602#discussion_r3990564007 PR Review Comment: https://git.openjdk.org/jdk/pull/32602#discussion_r3990578773
