On Wed, 16 Sep 2026 10:56:08 GMT, Daniel Fuchs <[email protected]> wrote:
>> Hello! The additional check in the constructor was intended as a defensive >> check against possible future changes in the parser, but since >> `Rfc2253Parser.parseRdn()` is responsible for validating the RDN and >> `doParse()` now rejects an empty RDN, the constructor check is redundant. >> >> I'll remove it and keep the validation in `Rfc2253Parser`. > > You could consider adding: > > > assert !entries.isEmpty(); > > > instead. done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32648#discussion_r4025465726
