On Wed, 16 Sep 2026 13:09:34 GMT, Daniel Fuchs <[email protected]> wrote:
>> Timofei Fedotov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Add new subtests in regression test >> - Add assert in Rdn constructor > > src/java.naming/share/classes/javax/naming/ldap/Rdn.java line 172: > >> 170: throw new InvalidNameException( >> 171: "RDN cannot be empty, got: \"" + rdnString + "\""); >> 172: } > > This is what I meant: > > Suggestion: > > assert !entries.isEmpty(); > > With your fix, the parser is already supposed to throw in that case, so we > can simply assert here. Okay ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32648#discussion_r4026409267
