On Wed, 16 Sep 2026 11:03:05 GMT, Daniel Fuchs <[email protected]> wrote:
>> Timofei Fedotov has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Update regression test
>> - Change message in body InvalidNameException
>> - Add numAttributes method and correct Rfc2253Parser
>> - Correct comment and move throw inside if
>
> test/jdk/javax/naming/ldap/Rdn/EmptyRdnTest.java line 1:
>
>> 1: /*
>
> I believe the test should also check the other methods by which an empty RDN
> might be created, even if those currently appropriately throw an
> InvalidNameException.
> (e.g. `new Rdn(new BasicAttributes())`)
>
> We also need a scenario that deserializes an empty RDN() (bytes that were
> formed on a previous version where new Rdn("") didn't throw) and verify that
> StreamCorruptedException is raised.
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32648#discussion_r4025466740
