On Mon, 14 Sep 2026 19:33:22 GMT, Vladimir Ivanov <[email protected]> wrote:

> Any tests on LF interpreter (w/ `COMPILE_THRESHOLD > 0`)?

I've added one now. Also fixed an issue when using variadic method handles and 
going through the LF interpreter.

> src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java line 2272:
> 
>> 2270:     }
>> 2271: 
>> 2272:     private static LambdaForm makeSynchronizeForm(MethodType 
>> basicType) {
> 
> It's worth adding a comment describing LambdaForm shape. Take a look at 
> `makeGuardWithCatchForm()` and `makeTryFinallyForm()`. They both feature 
> illustrative comments.

I've added a comment similar to those in 
https://github.com/openjdk/jdk/pull/32817/changes/91bcea2095c92d60883b1c966576a08451f334c1

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32817#issuecomment-5698520005
PR Review Comment: https://git.openjdk.org/jdk/pull/32817#discussion_r4026719100

Reply via email to