On Fri, 11 Sep 2026 21:00:08 GMT, Quan Anh Mai <[email protected]> wrote:
>> Boris Ulasevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> similar case for negative step > > src/hotspot/share/opto/loopnode.cpp line 4627: > >> 4625: PhiNode* phi2 = out->as_Phi(); >> 4626: Node* incr2 = phi2->in(LoopNode::LoopBackControl); >> 4627: // Look for an index that repeats the trip counter one iteration >> late: > > I would prefer this being a different method since we are looking at a pretty > different shape here. I would still suggest splitting this part into a separate method. You can have `PhaseIdealLoop::replace_parallel_iv` calls `replace_lagging_index` and `replace_independent_index`. Having entangled logic makes it harder to comprehend and make change when necessary. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32549#discussion_r4043080550
