On Thu, 17 Sep 2026 12:51:57 GMT, Per Minborg <[email protected]> wrote:

>> This PR proposes removing the entire internal `BufferStack` and associated 
>> classes and tests. Instead, we can now simply rely on a `Arena.ofConfined` 
>> which will provide pooling for us automatically.
>> 
>> If integrated, this PR would imply:
>> 1,511 lines removed net across 13 files compared with master:
>> - 602 production-source lines
>> - 909 test and benchmark lines
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Per Minborg has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove methods in SlicingAllocator

Good cleanup overall.

src/java.base/share/classes/jdk/internal/foreign/abi/SharedUtils.java line 398:

> 396:     }
> 397: 
> 398:     public static record BoundedArena(Arena delegate, SegmentAllocator 
> allocator) implements Arena {

I think this record don't need to be public and don't need to be explicitly 
static.

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/32924#pullrequestreview-5243915113
PR Review Comment: https://git.openjdk.org/jdk/pull/32924#discussion_r4043515663

Reply via email to