On Fri, 18 Sep 2026 07:01:55 GMT, Quan Anh Mai <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge branch 'master' of github.com:openjdk/jdk into
>> fix/vector-reinterpret-cliff
>> - Tweak asByteVectorRawTemplate to avoid reversal for bytes
>> - Introduce a regression test
>> - 8392004
>> - Try to fix sublane swap inline
>
> test/hotspot/jtreg/compiler/vectorapi/reshape/TestAsVectorAllocation.java
> line 40:
>
>> 38: import jdk.test.lib.RandomFactory;
>> 39:
>> 40: import java.util.Random;
>
> Should this import be ordered above the `jdk` ones?
Many code styles group java. and javax. imports in the bottom. I don't see a
preference in the JDK. I would recommemd creating a global code style file and
run it once if we want to fix that.
> test/hotspot/jtreg/compiler/vectorapi/reshape/TestAsVectorAllocation.java
> line 70:
>
>> 68:
>> 69: @Test
>> 70: @IR(failOn = {IRNode.SAFEPOINT_SCALAROBJECT_OF, ".*"})
>
> You should `failOn` `AllocateNode`, too.
Don't think that node existed in the problematic old IR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32803#discussion_r4046284568
PR Review Comment: https://git.openjdk.org/jdk/pull/32803#discussion_r4046291644
