On Sat, 19 Sep 2026 07:57:47 GMT, Alan Bateman <[email protected]> wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test: fix system id
>
> src/java.xml/share/classes/jdk/xml/internal/AccessRule.java line 52:
>
>> 50: * <li><b>scheme</b>: The URI scheme (e.g., http, https, ftp, file,
>> jrt).</li>
>> 51: * <li><b>host</b>: Domain name, IPv4, or IPv6 address. For local
>> schemes ("file", "jrt"), host is omitted.</li>
>> 52: * <li><b>port</b>: (optional) Port number to match. If omitted,
>> matches the default port for the scheme.</li>
>
> Is it default port or all ports?
all ports. Added test cases for all ports and specified port.
> src/java.xml/share/classes/module-info.java line 1043:
>
>> 1041: * <tr>
>> 1042: * <td id="RES_ACCESS">{@systemProperty jdk.xml.resource.access}</td>
>> 1043: * <td>Defines allowed network access to external resources by
>> specifying a list
>
> "network" should probably be dropped from this sentence, or have it use "file
> or network" as an example.
"network" dropped.
> src/java.xml/share/classes/module-info.java line 1111:
>
>> 1109: * Example:
>> 1110: * {@snippet :
>> 1111: * jdk.xml.resource.access = https://*.sun.com, http://www.w3.org,
>> https://127.0.0.1, file:/dtds/, jrt:*, file:/tmp/foo.jar
>
> `file:/dtds/` or `file:/dtds/*` ?
fixed. Wildcard must be specified in accordance with the spec. Added test cases.
> src/java.xml/share/classes/module-info.java line 1116:
>
>> 1114: * <ul>
>> 1115: * <li>https access to any subdomain of sun.com, e.g.
>> java.sun.com</li>
>> 1116: * <li>Resources from specific domain as listed in the example,
>> w3.org, 127.0.0.1</li>
>
> a specific domain or from the specified domain?
"the" specified domain as listed in the example.
> src/java.xml/share/conf/jaxp.properties line 157:
>
>> 155: #
>> 156: # Example:
>> 157: # jdk.xml.resource.access = https://*.sun.com, http://www.w3.org,
>> https://127.0.0.1, file:/dtds/, jrt:*, file:/tmp/foo.jar
>
> Same question `file:/dtds/` vs. `file:/dtds/*` on the examples in the
> properties file,.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32098#discussion_r4056163454
PR Review Comment: https://git.openjdk.org/jdk/pull/32098#discussion_r4056159336
PR Review Comment: https://git.openjdk.org/jdk/pull/32098#discussion_r4056160291
PR Review Comment: https://git.openjdk.org/jdk/pull/32098#discussion_r4056160950
PR Review Comment: https://git.openjdk.org/jdk/pull/32098#discussion_r4056161967
