On Tue, 22 Sep 2026 09:44:20 GMT, Dušan Bálek <[email protected]> wrote:

>> The proposal here is to:
>> - Correct the man page description of the `--module-path` option, which 
>> incorrectly suggests using of the `JAVA_HOME` environment variable. The 
>> description should be aligned with the existing wording in `jlink --help`.
>> - Expand the descriptions of the `--strip-debug` option in the man page and 
>> `jlink --list-plugins` to explain what kinds of Java and native debug 
>> information are removed from the output image.
>> - Expand the description of the `--strip-java-debug-attributes` option in 
>> `jlink --list-plugins` to explain which debug attributes are removed from 
>> class files.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Dušan Bálek has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Updating --module-path option description for man page.

src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties line 56:

> 54: \                                        module path must contain all 
> target-platform\n\
> 55: \                                        modules required to create the 
> image,\n\
> 56: \                                        including java.base.

The man page is good in the latest version. The usage message still have "For 
cross-platform linking ..." so different wording. Maybe this is too much detail 
for the usage message and this sentence should be dropped here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32926#discussion_r4070844459

Reply via email to