On Tue, 22 Sep 2026 09:20:57 GMT, Arno Zeller <[email protected]> wrote:
> Adjust the THRESHOLD constant to use _adjustTimeout_() so it scales > appropriately with the test environment's timeout factor, consistent with > other tests such as TcpTimeout.java. Reduced the default value from 3000 ms > to 2000 ms. > > The value is additionally capped at 9 seconds to ensure it stays well below > the full exponential backoff retry cycle (1 + 2 + 4 + 8 = 15 s), preserving > the test's intent of verifying that an ICMP Port Unreachable response causes > a quick failure rather than waiting through all retries. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). test/jdk/com/sun/jndi/dns/ConfigTests/PortUnreachable.java line 55: > 53: // retry cycle (1 + 2 + 4 + 8 = 15s), ensuring we verify that ICMP > Port > 54: // Unreachable causes a quick fail rather than waiting through all > retries. > 55: private static final long THRESHOLD = Math.min(adjustTimeout(2000), > 9000); The comment says "Capped at 10s", but the code caps at 9000 ms (9 s), which matches the PR description ("capped at 9 seconds"). Could you update the comment to say 9s? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33000#discussion_r4071256040
