On Wed, 23 Sep 2026 18:20:39 GMT, Vladimir Ivanov <[email protected]> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Avoid accidental deopts due to scope closure in warmup
>
> src/hotspot/share/prims/scopedMemoryAccess.cpp line 120:
>
>> 118: }
>> 119:
>> 120: static frame get_last_frame(JavaThread* jt, RegisterMap* register_map) {
>
> Nit: why is it a pointer and not a reference?
No particular reason. `frame::oops_do` requires a pointer, so I either take the
address of the register map in the caller or in this function.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30926#discussion_r4093854720
