On Mon, 28 Sep 2026 16:25:05 GMT, Naoto Sato <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments (replace isDirty and hasSameRules for equals) +
>> simplify modified zone test a little
>
> src/java.base/share/classes/java/text/SimpleDateFormat.java line 1310:
>
>> 1308: // Only check against instances of ZoneInfo, since the
>> standard JDK timezones
>> 1309: // are guaranteed to extend this internal type.
>> 1310: if (tz instanceof ZoneInfo zi && !zi.isDirty()) {
>
> The `dirty` flag is always set to `true` if an instance is created from
> deserialization (for compatibility with JDK 1.4 😮). We would need to
> introduce a "true" dirty flag for this purpose.
Updated with your suggestions. As discussed offline, `equals` might be a better
alternative without introducing more baggage.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33074#discussion_r4125607350
