On Mon, 28 Sep 2026 14:57:17 GMT, Quan Anh Mai <[email protected]> wrote:
>> Boris Ulasevich has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - collect the outputs of the CountedLoopNode, then traverse the list >> - fix the style in the section: pointer placement and extra spaces > > src/hotspot/share/opto/loopnode.cpp line 4618: > >> 4616: >> 4617: // Visit all children, looking for Phis >> 4618: Node_List outs; > > We should add a `ResourceMark` here to allow the memory used by the > `Node_List` to be reclaimed as soon as possible. We often add the `ResourceMark` right before the allocation so we don't need to run the constructor and destructor if the method returns before the list is created. In addition, please also add a comment saying why we need to collect the outputs of `cl` into a list instead of traversing and processing them at the same time. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32549#discussion_r4128628907
