Re: RFR: 8393242: jlink fails with "Multiple modules contain non-empty package" for a non-package resource directory in more than one module [v2]

[Dušan Bálek]

On Thu, 1 Oct 2026 10:02:32 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Dušan Bálek has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Comment updated
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java 
> line 210:
> 
>> 208:             // (empty) package and anything under "META-INF". However, 
>> these should
>> 209:             // not have entries in the "/packages" directory.
>> 210:             packageToModules.keySet().removeIf(p -> 
>> !Checks.isPackageName(p));
> 
> Good, just wondering if the comment should be updated too.

Comment updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33162#discussion_r4154417956