On Fri, 2 Oct 2026 16:32:57 GMT, Aleksey Shipilev <[email protected]> wrote:

>> src/java.base/share/classes/java/lang/runtime/ValueObjectMethods.java line 
>> 43:
>> 
>>> 41: final class ValueObjectMethods {
>>> 42:     private static final Unsafe UNSAFE = Unsafe.getUnsafe();
>>> 43:     private static final boolean VERBOSE = false;
>> 
>> Now that the `VERBOSE` field is not configurable dynamically, should it 
>> simply be removed from the source code? Changing its value for debugging 
>> purposes would now require to change the source code and recompile anyway. 
>> So the manual source modifications could include adding the 
>> debugging/logging code too.
>
> I find these flags still useful, so I can flip it in _one place_ instead of 
> changing a whole lot of code. So just putting this flag to default `false` is 
> good.

Yes I think enabling verbose debugging via a single change is still a good 
thing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33173#discussion_r4190697569

Reply via email to