On Fri, 9 Oct 2026 01:47:21 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which proposes to address the issue >> noted in https://bugs.openjdk.org/browse/JDK-8393884? >> >> When `java` is launched using `java -jar <jarfile>`, the native C code in >> the launcher, parses the manifest of the JAR file to detect the presence of >> any `SplashScreen-Image` manifest attribute. If the manifest file is missing >> in the JAR file, then it throws an error and exits the launcher. >> https://bugs.openjdk.org/browse/JDK-8392966 recently introduced a test which >> verifies the error message text in the absence of a manifest file in the JAR. >> >> When the `java.awt.headless` system property is set to `true`, then the >> launcher code skips the code meant to lookup the manifest file from the JAR >> and parse the `SplashScreen-Image` manifest attribute. Instead, at a later >> point in the code path, the Java side of the launcher tries to lookup the >> manifest file. This Java code throws a different error message when the >> manifest is missing from the JAR file. As a result, the newly introduced >> test now fails due to the unexpected error message. >> >> The change in this PR now updates the other error message to match the one >> we had introduced in JDK-8392966. As a result, even when the >> `java.awt.headless` system property is set to `true`, the error message will >> now be the same as the one when that property isn't set. The test now passes >> with this change. >> >> tier testing is currently in progress in our CI. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > adjust test Hello Matthias, > Will > [launcher_de.properties](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/launcher/resources/launcher_de.properties) > and the others get translations in another PR ? The localization changes are done separately once per release (just as an example, here's one such past issue https://bugs.openjdk.org/browse/JDK-8385927). > btw. is the final Path jarFile = Files.createTempFile(Path.of("."), "8392966-", ".jar"); > file in tmp file somewhere removed? That temporary file won't be created in the "/tmp" directory. Instead, it is intentionally created in the scratch directory of jtreg. jtreg manages the scratch directories for each test and if the test passes then the directory is deleted and if it fails then the directory is retained for debugging the failure (this can be configured when launching jtreg, through the `-retain` option). ------------- PR Comment: https://git.openjdk.org/jdk/pull/33268#issuecomment-6078271969
