On Thu, 15 Oct 2026 20:27:29 GMT, Bill Huang <[email protected]> wrote:
> The JEP 401 integration added VClass value-class variants to 25 tests in > test/jdk/java/util/Collections. These variants duplicate existing test logic > and don't add meaningful coverage: > > Most of these tests already have an Integer or Boolean path. Tier 6 runs the > valhalla_adopted group with --enable-preview, and under preview those box > classes are value classes, so the existing paths already send value objects > through the collections. > In the rest, the collection only stores, compares or iterates its elements. > That works the same for value objects, and the underlying operations are > covered by the dedicated value-class tests under test/jdk/valhalla/valuetypes > and test/hotspot/jtreg/runtime/valhalla. > > Collections/Ser.java is unchanged: its value-class case covers serializing a > collection that contains a value object, which isn't covered elsewhere. It > will be followed up in a separate PR under > [JDK-8384611](https://bugs.openjdk.org/browse/JDK-8384611). > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Marked as reviewed by smarks (Reviewer). Good. This reverts the java/util/Collections tests to their pre-Valhalla state, with the exception of Ser.java (as noted in the description) and CheckedIdentityMap.java and CheckedListBash.java, which contain changes unrelated to the VClass stuff. ------------- PR Review: https://git.openjdk.org/jdk/pull/33391#pullrequestreview-5540692477 PR Comment: https://git.openjdk.org/jdk/pull/33391#issuecomment-6203576253
