On Thu, 15 Oct 2026 23:19:53 GMT, Justin Lu <[email protected]> wrote:

> Make CNF plural rule handling use possessive grouped matching. Non-possessive 
> matching is not required, because the different components do not conflict 
> with each other. In practice, these test cases are unrealistic. However, they 
> are still within the defined implementation limits.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

LGTM

test/jdk/java/text/Format/CompactNumberFormat/PluralProcessingTest.java line 57:

> 55:     void longPluralRulesTest(String rule) {
> 56:         new CompactNumberFormat("#", 
> DecimalFormatSymbols.getInstance(Locale.ROOT),
> 57:                 new String[]{""}, rule);

This could be wrapped with `assertDoesNotThrow` to make the test's intention 
more explicit.

-------------

PR Review: https://git.openjdk.org/jdk/pull/33394#pullrequestreview-5551687076
PR Review Comment: https://git.openjdk.org/jdk/pull/33394#discussion_r4297697182

Reply via email to