On Tue, 20 Oct 2026 06:37:27 GMT, Jaikiran Pai <[email protected]> wrote:
>> test/jdk/tools/launcher/MiscTests.java line 85: >> >>> 83: mainClass >>> 84: ); >>> 85: final OutputAnalyzer oa = launchJava(javaCmdArgs); >> >> Can't we just change to use ` executeLimitedTestJava` here? > > Hello David, the `ProcessTools.executeLimitedTestJava(...)` does additional > things with the classpath: > > > * <p>Unless the "test.noclasspath" property is "true" the > * classpath property "java.class.path" is appended to the command > * line and the environment of the ProcessBuilder is modified to > * remove "CLASSPATH". > > So I didn't want it to interfere with this test in any manner. But from your description of the problem, now that this test won't run when started by a VirtualThread, and it requires a flagless invocation, then the two problems you describe can't happen and we don't even need to make this change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33345#discussion_r4324658813
