On Thu, 22 Oct 2026 11:59:51 GMT, Matthias Baesken <[email protected]> wrote:
>> When testing the gcc flag '-Wunused-macros' to warn about unused macros, a >> couple of unused macros have been reported by the compiler, that could be >> removed. >> >> https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-macros >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Remove changes from pngpread.c because this is 3rd party stuff Copyrights need to be updated. src/jdk.hotspot.agent/share/native/libsaproc/sadis.c line 60: > 58: #include <errno.h> > 59: > 60: #ifndef _WINDOWS Is the sys/param.h include needed now that we don't need to reference MAXPATHLEN. src/jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c line 74: > 72: // seems the strange define was for Solaris > 73: // #define _STRUCTURED_PROC 1 > 74: #include <sys/procfs.h> Yes, for solaris, including the sys/procfs.h include. I think you can get rid of that too, and the comments. ------------- PR Review: https://git.openjdk.org/jdk/pull/33468#pullrequestreview-5616899458 PR Review Comment: https://git.openjdk.org/jdk/pull/33468#discussion_r4350422312 PR Review Comment: https://git.openjdk.org/jdk/pull/33468#discussion_r4350525953
