On Tue, 27 Oct 2026 11:10:18 GMT, Viktor Klang <[email protected]> wrote:

>>>and consequently short-circuit catch clauses, e.g., catch (TimeoutException 
>>>...) might get skipped.
>> 
>> I might be missing something, but the contents of the try-body needs to 
>> execute before the finally, so the TimeoutException will be thrown *before* 
>> pool.close() is called (and then subsequently be handled by the catch). What 
>> might be affected though, is the dumping of threads, which is indeed an 
>> oversight. Let me open another issue to do the double-try (which also means 
>> that I can update the copyright year.
>
> Opened https://bugs.openjdk.org/browse/JDK-8395898

> I might be missing something, but the contents of the try-body needs to 
> execute before the finally, so the TimeoutException will be thrown before 
> pool.close() is called (and then subsequently be handled by the catch).

Correct. But, in the new version, if `pool.close()` blocks due to stale 
workers, `catch(TE)` will not get invoked.

> Opened https://bugs.openjdk.org/browse/JDK-8395898

Thanks so much @viktorklang-ora. Checking it right away.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33453#discussion_r4388318864

Reply via email to