On Wed, 28 Oct 2026 23:30:45 GMT, Sandhya Viswanathan
<[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolution
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1432:
>
>> 1430: lea(rbase,
>> ExternalAddress(StubRoutines::x86::vector_byte_shift_gfni_matrix() + kind *
>> 8 * BytesPerLong));
>> 1431: if (vlen_enc == Assembler::AVX_128bit) {
>> 1432: movddup(dst, Address(rbase, rtmp, Address::times_8));
>
> Here and in the else path rbase or rtmp could be used in place of dst. Then
> we don't have to do Temp dst.
Ignore this comment, the destination needs to be a xmm register so rbase or
rtmp can't be used as dst.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33113#discussion_r4429122180
