On Tue, 3 Nov 2026 20:40:11 GMT, Vladimir Ivanov <[email protected]> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Review comments resolution
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1433:
> 
>> 1431:   // One matrix per count in 0..31.
>> 1432:   const int mats_per_kind = 32;
>> 1433:   lea(rbase, 
>> ExternalAddress(StubRoutines::x86::vector_byte_shift_gfni_matrix() + kind * 
>> mats_per_kind * BytesPerLong));
> 
> How does it work with AOT code caching? Only base address is known to the 
> JVM, so it can miss updating the address in generated code when loading it 
> from AOT cache.

I have created 3 separate stubs for logical left, logical right and arithmetic 
right shift on the lines of vector_iota_indices.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33113#discussion_r4463919130

Reply via email to