On Wed, 4 Nov 2026 19:41:46 GMT, Naoto Sato <[email protected]> wrote:
>> make/jdk/src/classes/build/tools/generatecharacter/SpecialCaseMap.java line
>> 64:
>>
>>> 62: SpecialCaseMap item = parse(line.trim());
>>> 63: if (item != null &&
>>> 64: item.getCharSource() >> 16 == plane) {
>>
>> I presume it is intentional that we no longer end early when the item's
>> plane is greater than the passed plane? Is it worth describing the
>> expectations in the method javadoc? i.e., the items in the file are no
>> longer ordered by plane.
>
> Yes, it was intentional. I am not sure whether to explain it in the comment,
> as it was an incorrect assumption on the order of the input lines, which was
> never claimed to be guaranteed. The modified code does what it is expected to
> do. So I'd just leave it as it is.
That is a fair point.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33705#discussion_r4472598914
