On Thu, 5 Nov 2026 18:38:03 GMT, Chen Liang <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Simplify position check after skip >> - Improve final position & read assertion in test >> - Rename test's `expectedPosition` to `initialPosition` >> - Move file creation to `test()` > > test/jdk/java/io/RandomAccessFile/SkipBytes.java line 59: > >> 57: size + 1, >> 58: Integer.MAX_VALUE - 1, >> 59: Integer.MAX_VALUE > > Why not try some long-exclusive values here like Long.MAX_VALUE - 1L? That would result in attempt to seek to file positions beyond the maximum file size on some file systems and depends on the block size on others. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33649#discussion_r4484737788
