On Fri, 6 Nov 2026 22:32:08 GMT, Vladimir Ivanov <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolution
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1437:
>
>> 1435: cmpl(rtmp, 31);
>> 1436: jccb(Assembler::belowEqual, count_in_range);
>> 1437: stop("byte shift count out of 0..31");
>
> Do you also need `popf()` on failure path? Otherwise, VM error reporter can
> have problems with stack unwinding.
Hi @iwanowww , Yes its needed on failue path.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33113#discussion_r4499081649
