Could I have a review of a PR that fixes a bug in the JFR instrumentation of
RandomAccessFile?
The problem is that readLine() may produce an event with non-zero number of
bytes read and EOF at the same time. To ensure that we get the correct number
of bytes, we can't just take the length of the returned String, since
readLine() may read one ('\n') or two bytes ('\r\n') for line endings.
I added a test that verifies that readLine() returns the same result and leaves
the file pointer at the same position with or without JFR enabled.
Testing: jdk-tier2 + test/jdk/jdk/jfr
Thanks
Erik
---------
- [x] I confirm that I make this contribution in accordance with the [OpenJDK
Interim AI Policy](https://openjdk.org/legal/ai).
-------------
Commit messages:
- Fix whitespace
- Make into one method
- Initial
Changes: https://git.openjdk.org/jdk/pull/33637/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=33637&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8396523
Stats: 210 lines in 4 files changed: 167 ins; 28 del; 15 mod
Patch: https://git.openjdk.org/jdk/pull/33637.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/33637/head:pull/33637
PR: https://git.openjdk.org/jdk/pull/33637
