On Thu, 29 Oct 2026 17:56:27 GMT, Erik Gahlin <[email protected]> wrote:
> Could I have a review of a PR that fixes a bug in the JFR instrumentation of
> RandomAccessFile?
>
> The problem is that readLine() may produce an event with non-zero number of
> bytes read and EOF at the same time. To ensure that we get the correct number
> of bytes, we can't just take the length of the returned String, since
> readLine() may read one ('\n') or two bytes ('\r\n') for line endings.
>
> I added a test that verifies that readLine() returns the same result and
> leaves the file pointer at the same position with or without JFR enabled.
>
> Testing: jdk-tier2 + test/jdk/jdk/jfr
>
> Thanks
> Erik
>
>
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK
> Interim AI Policy](https://openjdk.org/legal/ai).
src/java.base/share/classes/java/io/RandomAccessFile.java line 1045:
> 1043: while (!eol) {
> 1044: c = read0();
> 1045: if (c >= 0) {
I don't see any correctness issues with the change, just a bit inconsistent to
use c >= 0 here and -1 in the switch. Same thing with `d`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33637#discussion_r4458508119
