On Tue, 10 Nov 2026 12:17:35 GMT, Alan Bateman <[email protected]> wrote:
>> Kieran Farrell has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update tests > > src/java.base/share/classes/jdk/internal/launcher/SecuritySettings.java line > 26: > >> 24: */ >> 25: >> 26: package jdk.internal.launcher; > > As per a previous comment, I think we need to find a better home for this to > avoid having jcmd calling into "launcher" code. This was resolved following an offline discusion. The showSettings related code that was extracted from sun.launcher.LauncherHelper into ShowSettings and moved along with SecuritySettings to a new package `jdk.internal.launcher`. To maintain modularity and make it clear that this is no longer launcher specific code, this new package has been renamed it to `jdk.internal.settings` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31742#discussion_r4552529004
