On Wed, 11 Nov 2026 14:03:22 GMT, Nizar Benalla <[email protected]> wrote:

>> src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor14.java
>>  line 47:
>> 
>>> 45:  * @since 14
>>> 46:  */
>>> 47: @SupportedSourceVersion(RELEASE_29)
>> 
>> Aside: it would be nice if we could have a CURRENT_RELEASE value and use 
>> that and so avoid editing these files every release.
>
> I can look into this, I do use an ad-hoc script to mass update these values

A few comments here:

One point assume another small source diff solution would be to using a 
CURRENT_RELEASE static final variable set to RELEASE_$N and do a one-time 
change to `@SupportedSourceVersion(CURRENT_RELEASE)`. However, the latter 
pattern is _not_ accepted by the language. An annotation referencing an enum 
value must include the value directly and not a constant that resolve to a 
value.

Updating the annotation in each of these visitor files is one in lieu of much 
larger potential changes, like introducing a new visitor file per release. So 
while the update may be tedious, it is better than the known alternatives for 
handling the modeling task in question.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33763#discussion_r4554556347

Reply via email to