On Wed, 11 Nov 2026 12:14:52 GMT, Bhavana Kilambi <[email protected]> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Review comments resolution
>
> test/hotspot/jtreg/compiler/vectorapi/TestFloat16VectorRearrange.java line 59:
> 
>> 57:     private static final int[] ID64  = identity(S64.length());
>> 58:     private static final int[] REV64 = reverse(S64.length());
>> 59:     private static final boolean[] ALT64 = alternating(S64.length());
> 
> Instead of just identity, reverse and alternating indices, could we test some 
> irregular order indices as well? something like - 
> 
> `private static final int[] RANDOM128 = {2, 3, 3, 4, 0, 1, 5, 7};`

Addressed, added a random index generator.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33198#discussion_r4559987746

Reply via email to