On Fri, 13 Nov 2026 16:41:38 GMT, Lance Andersen <[email protected]> wrote:
>> Please review this PR which moves the CEN Header size validation in >> ZipOutputStream::writeCEN after the extended timestamp calculation which can >> result in the extra field length and extra field data being modified. >> >> Mach5 tier1 - tier3 ran cleanly >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Lance Andersen has updated the pull request incrementally with one additional > commit since the last revision: > > Add suggested null check Still looks good, except for a typo in the test's message. test/jdk/java/util/zip/ZipOutputStream/ZipOutputStreamMaxCenHdrTest.java line 182: > 180: assertInstanceOf(ZipException.class, e); > 181: String emsg = e.getMessage(); > 182: assertNotNull(emsg, "Excpected ZipException message!"); Typo - should have been "Expected" ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/33801#pullrequestreview-5900384994 PR Review Comment: https://git.openjdk.org/jdk/pull/33801#discussion_r4570529093
